This repository has been archived by the owner on Jan 11, 2018. It is now read-only.
fix new branch crash #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
|
Feel free to merge when it's ready. Btw, here's the roadmap for strider: https://github.com/Strider-CD/strider/blob/master/ROADMAP.md You can see they made some other bug fixes around git webhooks like Strider-CD/strider#286 |
|
I see... that one is apparently related to express framework version upgrade they did. The github part became a plug-in module in 1.4, but it looks like the bug may still be there, the code looks similar to what it was before the change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verified that strider process no longer crashes