refactor: Support ESM (maintaining support for CJS) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcburnie
changed the title
agliga
reviewed
Feb 2, 2022
| //const ExitEmitter = require('../../packages/makeup-exit-emitter'); | ||
|
|
||
| // IMPORT | ||
| import * as ExitEmitter from '../../packages/makeup-exit-emitter'; |
There was a problem hiding this comment.
I think it's fine for now, but the goal is to get to either importing default or importing each module as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(PLEASE SQUASH)
Fixes #35
This PR updates all module source to ES Module format.
A second distributable is generated that maintains support for older common JS
requiresyntax.I have tested with a standalone Lasso project, plus eBay Skin and MIND Patterns projects and everything seems to be working correctly. Once approved I will republish all packages.