Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading #38

Closed
makew0rld opened this issue Jul 3, 2020 · 2 comments
Closed

Downloading #38

makew0rld opened this issue Jul 3, 2020 · 2 comments
Labels
enhancement New feature or request roadmap A user-facing feature on the roadmap.
Milestone

Comments

@makew0rld
Copy link
Owner

Amfora should be able to download pages as well as any file.

  • There should be a downloads option in config.toml default set to "" which means the config package will figure out and use the default downloads folder for each platform
  • Page download
    • For pages, Page.Raw can just be written to a file easily
    • The downloading should happen in a goroutine, and display a Info modal when it's done, with the file path
    • There should be a page download mutex, so that multiple goroutines don't download the same page at once if the user spams the download button
    • Download page with Ctrl-S
  • Data download
    • Replace "Open in Portal" modal with buttons for downloading the data, using the portal, or cancelling
    • Progress bar in modal
      • This means you can't browse while downloading, or do multiple downloads at once, which is fine for now but could potentially be added later with difficulty
@makew0rld makew0rld added enhancement New feature or request roadmap A user-facing feature on the roadmap. labels Jul 3, 2020
@makew0rld makew0rld added this to the v1.3.0 milestone Jul 3, 2020
@makew0rld
Copy link
Owner Author

makew0rld commented Jul 9, 2020

makew0rld added a commit that referenced this issue Jul 9, 2020
@makew0rld
Copy link
Owner Author

makew0rld commented Jul 10, 2020

  • A size limit should be added to regular responses of 2 MiB, after that a download option is offered - this addresses Response size limit #30
  • A time limit should be added too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request roadmap A user-facing feature on the roadmap.
Projects
None yet
Development

No branches or pull requests

1 participant