strange paste behaviour for address bar on Windows

[LukeEmmet]

I'm seeing a strange behaviour - when I try to paste a URL from the clipboard into Amfora on Windows (win10 x64) it seems to truncate the URL. Similar behaviour using the right mouse click or Edit->paste menu, both of which normally paste OK in other apps.

For example here I pasted the following URL: gemini://gemini.marmaladefoo.com/blog/7-Jul-2020_GemiNaut_v0_8_6_release.gmi

the truncation happens as you paste, before you hit enter to navigate to that URL. Amfora cannot navigate as the URL is broken.

[makew0rld]

Just wanted to add this here, it was discussed on IRC a while back when the issue originally came up: This is likely due to interplay between the Windows terminal and the TUI library Amfora uses, cview. There isn't much I can do about it, other than file an upstream bug.

@LukeEmmet If you could compile and run this demo code and let me know if it exhibits the same behaviour that'd be helpful. It uses a regular cview inputfield, which would help confirm where the issue lies.

[LukeEmmet]

I downloaded and compiled the example. Yes it seems the problem is upstream, I get the same problem pasting a URL into that example. I tried adding another URL field with a bigger size, but still the same problem (I think the size is just the visible size not the length of data it will accept):

	AddInputField("URL", "", 400, nil, nil).

I pasted in the URL to the demo https://gitlab.com/tslocum/cview/-/blob/master/demos/form/main.go and you can see below the result.

So it seems to be a CView problem not Amfora.

[makew0rld]

Alright, thanks for confirming this!

I think the size is just the visible size not the length of data it will accept

Yes, that's correct.

Also I noticed this screenshot is using Windows Powershell, while the original screenshot seems like something different. Am I correct? What's the application in the first screenshot?

[makew0rld]

I filed issue 32 with cview.

[LukeEmmet]

The first one is just where the application is directly launched from Windows explorer I think.

[makew0rld]

This is a known issue in upstream libraries. It appears there are workarounds I could possibly implement.

[makew0rld]

This cview commit updates cview to use tcell v2 which has fixed the Windows paste issue. I am planning to update my cview version, so that this issue can be closed.

I will have to do a lot of testing because tcell v2 is unstable, but the short of it is that a fix is coming soon!

Edit: tslocum clarified the changes I'd have to make in this comment. Also waiting on an answer to gdamore/tcell#375, to make sure using truecolor is compatible across many terminals.

[makew0rld]

Work has begun on the cview-update branch, this will be in the next release likely.

[makew0rld]

#104 might be a better way to achieve this update, and then close this issue. I'll work towards merging that PR.

[makew0rld]

Self note

This might have to be moved off of the v1.6.0 milestone, as updating cview is introducing new bugs. See #107 for details. If I end up focusing on other v1.6.0 issues I might make a release that doesn't include this one. The other possibility is focusing on #107 and getting it in.

[makew0rld]

This has been fixed in #107, as tested by @LukeEmmet. This issue will be automatically closed once #107 is merged.