Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iceberg theme #239

Merged
merged 7 commits into from
May 27, 2021
Merged

Add iceberg theme #239

merged 7 commits into from
May 27, 2021

Conversation

KNIX3
Copy link
Contributor

@KNIX3 KNIX3 commented May 15, 2021

I just thought it might be nice to add the iceberg theme found here to the list. Here's a screenshot.
image

KNIX3 added 3 commits May 14, 2021 20:39
Added the iceberg vim theme (dark version) found [here](https://cocopon.github.io/iceberg.vim/)
Changed a couple colors for readablity
Cleaned up coloring of UI
@KNIX3 KNIX3 changed the title Patch 1 Add iceberg theme May 15, 2021
@makew0rld
Copy link
Owner

Thanks! Please add the screenshot to the contrib/themes/README.md file, as past PRs have done. See #221 as an example. It would also be nice if your screenshot has a left margin like the others do.

@KNIX3
Copy link
Contributor Author

KNIX3 commented May 17, 2021

I am more than willing to add such a screenshot, but what do you mean by a left margin? Is there a setting in amfora that adds a left margin or do you just want me to take the screenshot past the edge of the terminal?

@makew0rld
Copy link
Owner

By default Amfora adds a left margin to text, this can be seen in your screenshot. Strange if yours isn't, that could be a bug. This is controlled by the left_margin setting on the config.

@KNIX3
Copy link
Contributor Author

KNIX3 commented May 17, 2021

Ah, I found the setting, I don't know why mine was set to 0.0. I will change the image later today.

@makew0rld
Copy link
Owner

Thanks! Merged. Please subscribe to #149 so you can stay aware of updates that need to be added to this theme.

@makew0rld makew0rld merged commit 523ce6e into makew0rld:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants