You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm wondering if there is a reason for the inconsistent order of Figure and path arguments between save() and record(). Both save figures in one way or another, so I think it will be nice to make the order of the arguments consistent between them.
Specifically, when saving fig::Figure, we use save(path, fig). On the other hand, when saving an animation of a figure, we use record(fig, path, ...) do ... end. Is there a reason why record() uses the reversed order of arguments compared to save()?
It seems that most packages, if not all, in JuliaIO use the (path, data) order in save-like functions. Following this practice, I am wondering if we can change the order of argument in record() to record(path, fig, ...) do ... end.
The text was updated successfully, but these errors were encountered:
wsshin
changed the title
Make the location of Figure and path arguments consistent between save() and record()
Make the order of Figure and path arguments consistent between save() and record()
Feb 16, 2024
I've been confused by that as well. Maybe it would be good to add the other one, they wouldn't conflict type wise. Then the old signature could be deprecated.
I'm wondering if there is a reason for the inconsistent order of
Figure
andpath
arguments betweensave()
andrecord()
. Both save figures in one way or another, so I think it will be nice to make the order of the arguments consistent between them.Specifically, when saving
fig::Figure
, we usesave(path, fig)
. On the other hand, when saving an animation of a figure, we userecord(fig, path, ...) do ... end
. Is there a reason whyrecord()
uses the reversed order of arguments compared tosave()
?It seems that most packages, if not all, in JuliaIO use the
(path, data)
order in save-like functions. Following this practice, I am wondering if we can change the order of argument inrecord()
torecord(path, fig, ...) do ... end
.The text was updated successfully, but these errors were encountered: