chore(ops): setup a healthcheck engine #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using /healthcheck, a text string is served over an HTTP connection containing the current ping if the server is connected. If the server is not online, the request returns a status code of HTTP 503.
Do not deploy this commit until the new metrics can be ingested. It will remove the !ping command expecting that the metrics can now be poked using the HTTP server added in the previous commit, rather than having a process sending the `!ping` command over the #server-status channel every 5 minutes.
This was referenced Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit installs an HTTP server that will be used with monitoring and metrics endpoints that provide debug information as well as server status over a programmatic interface.
It is designed to deprecate the current interface of commands being thrown over the #server-status channel.
The first endpoint added provides both a binary healthcheck that will yield whether the server is ready or not, as well as the average ping for the latest heartbeats sent through the websocket. Because the metrics system can now retrieve the average ping over the metrics server, this commit also removes the !ping command.
Note that the /healthcheck endpoint does not provide metrics for RTT, which is OK.
Fixes #36