Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade threejs to 0.112 (workaround) #163

Merged
merged 7 commits into from
Jan 2, 2020
Merged

Upgrade threejs to 0.112 (workaround) #163

merged 7 commits into from
Jan 2, 2020

Conversation

makimenko
Copy link
Owner

  • upgraded threejs to 0.112
  • workaround applied (upgrade of typescript + polyfill)
  • increased test coverage

- Upgrade to Typescript 3.7.4 + workarounds
- angularCompilerOptions.disableTypeScriptVersionCheck=true
- added polyfills.ts: __importDefault
- Upgrade to Typescript 3.7.4 + workarounds
- angularCompilerOptions.disableTypeScriptVersionCheck=true
- added polyfills.ts: __importDefault
@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #163 into master will increase coverage by 9.66%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   68.25%   77.91%   +9.66%     
==========================================
  Files          77       78       +1     
  Lines         945      951       +6     
  Branches       92       94       +2     
==========================================
+ Hits          645      741      +96     
+ Misses        263      166      -97     
- Partials       37       44       +7
Impacted Files Coverage Δ
projects/atft/src/lib/atft.module.ts 100% <ø> (ø) ⬆️
projects/atft/src/lib/stats/stats.service.ts 80% <100%> (+66.66%) ⬆️
projects/atft/src/test.ts 80% <50%> (-20%) ⬇️
src/polyfills.ts 75% <75%> (ø)
...ojects/atft/src/lib/raycaster/raycaster.service.ts 39.34% <0%> (+3.27%) ⬆️
...ts/atft/src/lib/object/text/text-mesh.component.ts 77.5% <0%> (+5%) ⬆️
...tft/src/lib/object/helper/grid-helper.component.ts 100% <0%> (+42.85%) ⬆️
...tft/src/lib/object/helper/axes-helper.component.ts 100% <0%> (+50%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15e13e8...e8afea2. Read the comment docs.

@makimenko makimenko merged commit 38e0249 into master Jan 2, 2020
@makimenko makimenko deleted the 20191227 branch January 5, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant