Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#92 fix data binding in cylinder mesh #93

Merged
merged 2 commits into from Sep 3, 2019
Merged

#92 fix data binding in cylinder mesh #93

merged 2 commits into from Sep 3, 2019

Conversation

makimenko
Copy link
Owner

#92 fix data binding in cylinder mesh

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #93 into master will increase coverage by 1.49%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   42.85%   44.34%   +1.49%     
==========================================
  Files           8        8              
  Lines         112      115       +3     
  Branches       12       12              
==========================================
+ Hits           48       51       +3     
  Misses         64       64
Impacted Files Coverage Δ
...ft/src/lib/objects/mesh/cylinder-mesh.component.ts 64.7% <80%> (+7.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b30238...95c3f34. Read the comment docs.

@makimenko makimenko merged commit 1cb2986 into master Sep 3, 2019
@makimenko makimenko deleted the 92-fix-cylinder branch September 3, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant