Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook controls #94

Merged
merged 8 commits into from Sep 3, 2019
Merged

Storybook controls #94

merged 8 commits into from Sep 3, 2019

Conversation

makimenko
Copy link
Owner

  • Added @storybook/addon-knobs
  • added stories for AbstractObject3D OnChanges testing (translate and rotate)
  • Introduced defaultSceneWrapper (allows easy to focus on storybook component's inputs/knobs and actions testing)
  • Changed storybook options (name and url)

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #94 into master will increase coverage by 0.78%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   44.34%   45.13%   +0.78%     
==========================================
  Files           8        8              
  Lines         115      113       -2     
  Branches       12       12              
==========================================
  Hits           51       51              
+ Misses         64       62       -2
Impacted Files Coverage Δ
...rojects/atft/src/lib/objects/abstract-object-3d.ts 21.42% <100%> (+0.97%) ⬆️
.../atft/src/lib/objects/mesh/torus-mesh.component.ts 44.44% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb2986...49fc01f. Read the comment docs.

@makimenko makimenko merged commit 66f1e88 into master Sep 3, 2019
@makimenko makimenko deleted the sb-controls branch September 3, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant