Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation conversion float to int #169

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Fix deprecation conversion float to int #169

merged 1 commit into from
Jun 3, 2024

Conversation

maxhelias
Copy link
Contributor

Capture d’écran 2024-05-31 à 17 08 52

SimonMellerin
SimonMellerin requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@SimonMellerin SimonMellerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

First of all, thank you for your contribution.

We'd rather use an explicit floor cast for this one.

Also, as you modify these lines, I think it's more readable with multi-line .

Thanks

src/Helper/Format.php Outdated Show resolved Hide resolved
src/Helper/Format.php Outdated Show resolved Hide resolved
@SimonMellerin SimonMellerin self-requested a review June 3, 2024 12:26
@SimonMellerin SimonMellerin merged commit 2b88f92 into makinacorpus:main Jun 3, 2024
30 checks passed
@maxhelias maxhelias deleted the fix-deprecation-conversion branch June 3, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonMellerin SimonMellerin SimonMellerin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxhelias @SimonMellerin