Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attribute error when union queryset of safe delete model with others #152

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Fix attribute error when union queryset of safe delete model with others #152

merged 2 commits into from
Mar 15, 2021

Conversation

yuekui
Copy link
Contributor

@yuekui yuekui commented Mar 3, 2021 •
edited

  • Bug fix: A safedelete model queryset union with another regular model queryset will raise an attribute error:
    AttributeError: 'QuerySet' object has no attribute '_filter_visibility'

  • Also fixed 422 Client Error when submitting coverage.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.363% when pulling 9f39239 on yuekui:master into cb8b320 on makinacorpus:master.

@yuekui yuekui mentioned this pull request Mar 3, 2021
Closed
@Gagaro
Copy link
Member

Gagaro commented Mar 15, 2021

Thanks for the PR 👍 .

@Gagaro Gagaro merged commit 7bc29c2 into makinacorpus:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuekui @coveralls @Gagaro