Fix SafeDeleteQueryset.as_manager to return SafeDeleteManager #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwax
force-pushed
the
gwax/fix-queryset-as_manager
branch
from
5a23588
to
3933529
Compare
|
Thanks for the PR 👍 . There is an issue with typing, could you take a look at it? |
Calling the as_manager method on a SafeDeleteQueryset subclass previously created a SafeDelete naive manager. This commit overrides the as_manager method to properly return a SafeDeleteManager object.
gwax
force-pushed
the
gwax/fix-queryset-as_manager
branch
from
3933529
to
07b7304
Compare
|
@Gagaro , I believe the typing issue is resolved now |
|
Thanks again for the PR 👍 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling the as_manager method on a SafeDeleteQueryset subclass previously created a SafeDelete naive manager. This commit overrides the as_manager method to properly return a SafeDeleteManager object.