Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carry forward force_policy to the Queryset #74

Merged
merged 4 commits into from Apr 4, 2017

Conversation

srj55
Copy link
Contributor

@srj55 srj55 commented Apr 1, 2017

force_policy feature is currently only available on the model instances. Enable this feature for SafeDeleteQuerySet as well.

force_policy feature is currently only available on the model instances.  Enable this feature for SafeDeleteQuerySet as well.
@coveralls
Copy link

coveralls commented Apr 1, 2017

Coverage Status

Coverage remained the same at 97.642% when pulling fb007a2 on srj55:patch-1 into 21bdcbb on makinacorpus:master.

@Gagaro
Copy link
Member

Gagaro commented Apr 3, 2017

Hi, thanks for the PR 👍

Could you rebase on master, do the same for undelete and add the changelog in CHANGES?

Steve Jones added 2 commits April 3, 2017 12:15
force_policy feature is currently only available on the model instances. Enable this feature for SafeDeleteQuerySet as well.
@coveralls
Copy link

coveralls commented Apr 3, 2017

Coverage Status

Coverage remained the same at 97.79% when pulling 704a24d on srj55:patch-1 into 139a027 on makinacorpus:master.

@coveralls
Copy link

coveralls commented Apr 3, 2017

Coverage Status

Coverage remained the same at 97.79% when pulling 9711ecf on srj55:patch-1 into 139a027 on makinacorpus:master.

@coveralls
Copy link

coveralls commented Apr 3, 2017

Coverage Status

Coverage remained the same at 97.79% when pulling 9711ecf on srj55:patch-1 into 139a027 on makinacorpus:master.

@srj55
Copy link
Contributor Author

srj55 commented Apr 3, 2017

i've rebased, and also updated CHANGES.

For undelete, the _safedelete_policy isn't implemented, so 'force_policy' wouldn't apply. Perhaps we should add this feature to undelete in the future?

@Gagaro
Copy link
Member

Gagaro commented Apr 4, 2017

Indeed my bad. Thanks 👍 .

@Gagaro Gagaro merged commit 8173705 into makinacorpus:master Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants