-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Applicative Validation #121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it sounds natural, I'd like to change as follows:
Validation<ConstraintViolation, ContactInfo> validation = Validations.compose(emailValidator.composable().validate(email), phoneNumberValidator.composable().validate(phoneNumber)))
.apply(ContactInfo:new); |
review comments in Japanese from @gakuzzzz |
From @gakuzzzz 's feed back in https://gist.github.com/gakuzzzz/6acd31a9c7d1756ae6c2745442720a79#gistcomment-3741084 , I'm going to go with |
with JDK8 increses exponentially according to the number.
with JDK8 increses exponentially according to the number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduces an implementation similar to Vavr's
Validation
or Scalaz'sValidation
control class that is an applicative functor and facilitates accumulating errors.ApplicativeValidator
which can be obtained byValidator.applicative()
hasvalidate
method and it returnsValidation
object as follows:This API makes it possible to make different validation results composable.
It's more powerful than using
ValidatorBuilder.nest()
method for reusing a value object class.closes gh-119