Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo: negaitve -> negative #259

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Fix typo: negaitve -> negative #259

merged 2 commits into from
Jun 6, 2022

Conversation

JozsefKutas
Copy link
Contributor

This fixes a method name typo from negaitveOrZero to negativeOrZero in the constraint classes for numeric types.

@making
Copy link
Owner

making commented Jun 5, 2022

Thanks!
Can you please keep and deprecate the old methods?
I don’t want to make immediate breaking changes.

@making making added the enhancement New feature or request label Jun 5, 2022
@making making self-requested a review June 5, 2022 23:29
@making making added this to the 0.11.3 milestone Jun 5, 2022
@JozsefKutas
Copy link
Contributor Author

OK, I've re-added the old method and tests.

@making making merged commit 0215fd4 into making:develop Jun 6, 2022
@making
Copy link
Owner

making commented Jun 6, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@making making Awaiting requested review from making

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.11.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JozsefKutas @making