Add unwrap method to access ValidatorBuilder from Kotlin DSL #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
making
requested changes
Jun 7, 2022
| @@ -517,4 +517,5 @@ class ValidatorBuilderKt<T>(private val validatorBuilder: ValidatorBuilder<T>) { | |||
| ValidatorBuilderKt(it).apply(block).validatorBuilder | |||
| } | |||
|
|
|||
| @@ -28,6 +28,7 @@ import java.time.LocalTime | |||
| import java.time.OffsetDateTime | |||
| import java.time.ZonedDateTime | |||
| import java.time.temporal.ChronoUnit | |||
| import java.util.function.Predicate | |||
There was a problem hiding this comment.
Ah, soory. it's mistake 😢
be-hase
force-pushed
the
add-unwrap-method
branch
from
5e80633
to
846454f
Compare
making
changed the title
making
approved these changes
Jun 7, 2022
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Kotlin DSL(ValidatorBuilderKt) is very cool and convient.
However, there are some method that ValidatorBuilder has but does not exist in ValidatorBuilderKt.
(For example,
constraintOnTarget)Solution
Therefore, I want to be able to access the ValidatorBuilder held by the ValidatorBuilderKt.
Since there may be other methods that forget to support DSL in the future, I want to access ValidatorBuilder.