Fixing redis locking for 5000 seconds unintentionally #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karljin I think this PR is still valid right? |
manav
suggested changes
Apr 16, 2021
| @@ -15,13 +15,13 @@ | |||
|
|
|||
|
|
|||
| @contextlib.contextmanager | |||
| def simple_lock(lock_key, timeout=5000): | |||
There was a problem hiding this comment.
is 5 sec enough ? should we make it longer.
There was a problem hiding this comment.
it's always been meant to be 5 seconds. the fact that it's locking for 5000 seconds is purely accidental and "bad"
markhsu-ms
reviewed
Apr 20, 2021
manav
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same problem as what we see in transmissions