Implemented CCC #10
Merged
Implemented CCC #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try to apply the changes. |
makortel
pushed a commit
that referenced
this pull request
Feb 6, 2019
makortel
pushed a commit
that referenced
this pull request
Feb 13, 2019
makortel
pushed a commit
that referenced
this pull request
Feb 14, 2019
makortel
reviewed
Feb 27, 2019
| @@ -491,6 +495,14 @@ std::vector<const DetLayer *> MkFitProducer::createDetLayers(const mkfit::LayerN | |||
| return dets; | |||
| } | |||
|
|
|||
| bool MkFitProducer::passCCC(const SiStripRecHit2D& hit, const DetId hitId) const { | |||
| return (siStripClusterTools::chargePerCM(hitId,hit.firstClusterRef().stripCluster()) < 1620 ); | |||
There was a problem hiding this comment.
Should have been
return (siStripClusterTools::chargePerCM(hitId,hit.firstClusterRef().stripCluster()) >= 1620 );Lesson learned: don't merge anything without a round of validation.
makortel
pushed a commit
that referenced
this pull request
Mar 15, 2019
makortel
pushed a commit
that referenced
this pull request
Mar 25, 2019
makortel
pushed a commit
that referenced
this pull request
Jun 10, 2019
makortel
pushed a commit
that referenced
this pull request
Aug 13, 2019
makortel
pushed a commit
that referenced
this pull request
Sep 20, 2023
make startup allocations safe on platforms where dlsym allocates memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could probably be improved by making the exact cut value configurable, but for now it works.