Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the link to the datasource in RetailHero to a valid one + paths to datasets #116

Closed
wants to merge 2 commits into from

Conversation

Ksyula
Copy link
Contributor

@Ksyula Ksyula commented Jul 17, 2021


name: "Pull request"
about: Make changes in scikit-uplift

馃搼 Description of the Change

The link to original datasets seem to be outdated (goes to 404) in RetailHero notebooks (RU + EN)
The link is updated as well as the internal path to the datasets after unzipping the archive.

Verification Process

Run notebooks locally with the right data source link and the different folder name, the output of the notebooks is the same like it was before.

Release Notes

Not applicable

Additional info

@Ksyula Ksyula changed the base branch from master to dev July 17, 2021 20:17
@Ksyula Ksyula closed this Jul 18, 2021
@Ksyula
Copy link
Contributor Author

Ksyula commented Jul 18, 2021

The same issue will be solved here #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant