Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving pytest issues #517

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

pcagas
Copy link
Contributor

@pcagas pcagas commented May 30, 2024

No description provided.

… execution now uses an absolute path and the test results are also placed to pytest temp directory to avoid artefact generation.
@pcagas pcagas linked an issue May 30, 2024 that may be closed by this pull request
@pcagas pcagas self-assigned this May 30, 2024
@pcagas
Copy link
Contributor Author

pcagas commented May 30, 2024

  • Calling the tests with runpy now uses a path relative to the test file and not the current directory.
  • The tests are run from pytest temp directory so the artifacts don't pollute the current one.

@pcagas pcagas linked an issue May 31, 2024 that may be closed by this pull request
… is not found, it is loaded from hte test-data repository. In addition, `data_path` variable was added to the `datahandling` submodule which points directly to the `Be2` subdirectory
@pcagas
Copy link
Contributor Author

pcagas commented May 31, 2024

This should not be merged before mala-project/test-data#9

Copy link
Member

@RandomDefaultUser RandomDefaultUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @pcagas ! That in principle looks all great to me, and I think it is almost ready to merge. I would, however, move the newly added model in the data repository (as mentioned in mala-project/test-data#9 (review)), which then in turn requires an update to the reference model file in some of the tests.

The ones that need updating and fail elsewise are:

Screenshot from 2024-06-05 17-58-03

Also, the data repository has moved to a RODARE mirror system now.

So my suggestion would be to

  1. Adjusting Adding model file test-data#9 as per my review
  2. Merging Adding model file test-data#9
  3. Creating a new release for https://github.com/mala-project/test-data/
  4. Merge the MALA develop branch into this branch, which should give you the code for downloading from RODARE
  5. Adjust the download section in the workflow file to point to the correct version:
    updating_data_repository
  6. Fix the tests that break due to the updated model path (see above)

Then we should be good to merge!

@pcagas
Copy link
Contributor Author

pcagas commented Jun 6, 2024

@pcagas pcagas marked this pull request as ready for review June 7, 2024 11:55
Copy link
Member

@RandomDefaultUser RandomDefaultUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can be merged!

@RandomDefaultUser RandomDefaultUser merged commit e967711 into mala-project:develop Jun 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples_test.py cannot be run in parallel Tests in examples_test.py fail when run from outside the test dir
2 participants