-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving pytest issues #517
Resolving pytest issues #517
Conversation
… execution now uses an absolute path and the test results are also placed to pytest temp directory to avoid artefact generation.
|
… is not found, it is loaded from hte test-data repository. In addition, `data_path` variable was added to the `datahandling` submodule which points directly to the `Be2` subdirectory
This should not be merged before mala-project/test-data#9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @pcagas ! That in principle looks all great to me, and I think it is almost ready to merge. I would, however, move the newly added model in the data repository (as mentioned in mala-project/test-data#9 (review)), which then in turn requires an update to the reference model file in some of the tests.
The ones that need updating and fail elsewise are:
Also, the data repository has moved to a RODARE mirror system now.
So my suggestion would be to
- Adjusting Adding model file test-data#9 as per my review
- Merging Adding model file test-data#9
- Creating a new release for https://github.com/mala-project/test-data/
- Merge the MALA develop branch into this branch, which should give you the code for downloading from RODARE
- Adjust the download section in the workflow file to point to the correct version:
- Fix the tests that break due to the updated model path (see above)
Then we should be good to merge!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, can be merged!
No description provided.