Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVGs not loading in OSX & iOS Safari #28

Closed
stantonl33 opened this issue Oct 5, 2018 · 1 comment
Closed

SVGs not loading in OSX & iOS Safari #28

stantonl33 opened this issue Oct 5, 2018 · 1 comment
Assignees
@malchata
Labels
bug v2 (shadowfax)

Comments

@stantonl33
Copy link

stantonl33 commented Oct 5, 2018 •
edited
Loading

SVG files fail to load in Safari. The Javascript console has this error:

Unhandled Promise Rejection: EncodingError: Invalid image type.
[N] (anonymous function)
[N] promiseReactionJob

I made a test on plunker. You can use it to test here: https://next.plnkr.co/plunk/GJEd9DNdH9xRHzJanfau

Essentially the test loads a .jpg into the src attribute and an svg into the data-src attribute. I pasted the latest yall.js version (2.1.0) into the plunk script file and added jquery 3.1.1 above it.
@malchata malchata self-assigned this Oct 8, 2018
@malchata malchata added the bug label Oct 8, 2018
@malchata
Copy link
Owner

malchata commented Oct 8, 2018 •
edited
Loading

Able to repro in Safari on High Sierra. I'll triage this for now and get to it when I can, but I suspect I know what the culprit is. Thanks for catching and logging this!

malchata added a commit that referenced this issue Dec 15, 2018
@malchata
2.2.0 release
ffd5e5a 
- Added linting via eslint.
- Updated Babel to version 7.
- Added @babel/preset-env. May add a separate leaner build for mjs in the future.
- Resolved bugs #24 and #28 by removing async decoding via `Image.decode()`.
- Added features requested in #19 and #32.
- Updated documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malchata malchata

Labels
bug v2 (shadowfax)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malchata @stantonl33