Simplify trace_ray, remove heap mallocs #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thanks for a very nice and usable library.
In my effort to understand the
trace_ray
algorithm, I rewrote it a bit to remove explicit heap allocations. In my opinion, the result is a bit simpler, so it might be worthwhile to merge.Briefly, the ray
std::vector
now stores coordinates rather than pointers to coordinate triples. Amemoryview
is used to alias the active/last point inray
.It is probably a bit faster. I think there is also a slight difference in behaviour in that the endpoint itself is checked for NaN value, whereas before only the first step was checked.