Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kCLDistanceFilterNone value used as default for minDistance. #309

Merged
merged 1 commit into from Nov 28, 2020
Merged

kCLDistanceFilterNone value used as default for minDistance. #309

merged 1 commit into from Nov 28, 2020

Conversation

hamzaozturk
Copy link
Contributor

According to the current implementation, setting minDistance was not working. It was always setting the minDistance value to -1.

SwiftLocation/Sources/SwiftLocation/SwiftLocation.swift

Line 537 in 9f9a81b

settings.minDistance = min(settings.minDistance ?? -1, request.options.minDistance ?? -1)

Moreover, it is better using the default value of the distanceFilter of CLLocationManager. Therefore, i have updated the code to use it as default.

@malcommac
Copy link
Owner

thank you for spotting it @hamzaozturk. I'll merge it in 5.0.1

@malcommac malcommac changed the base branch from develop to 5.0.1 November 28, 2020 07:58
@malcommac malcommac added the bug label Nov 28, 2020
@malcommac malcommac added this to the 5.0.1 milestone Nov 28, 2020
@malcommac malcommac merged commit 11e5bf8 into malcommac:5.0.1 Nov 28, 2020
@hamzaozturk hamzaozturk deleted the min-distance-fix branch November 28, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hamzaozturk @malcommac