removed clickoutside hooks from calendar element #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is incomplete and more of a proof of concept.
Clickoutside is not native and does not play nice with any clicks that invoke
stopPropagation. This is especially apparent when usingreact-selectandreact-datepickeron the same page.Instead of refocusing after every blur of the datepicker input and only hiding the calendar
onClickOutside, we can hide the calendar when the datepicker is blurred except in the case where the blur is caused by a calendarmousedownwhere we set a flag that tells the datepicker to refocus and continue to show the calendar.