iOS compatibility #4
Open
+248
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
requested changes
Feb 5, 2019
There was a problem hiding this comment.
I will look at this in more detail later, but in the meantime, please read over the contributing docs and make sure your pull request follows that.
commoncrypto/Cargo.toml
Outdated
| @@ -11,11 +11,12 @@ license = "MIT" | |||
| travis-ci = { repository = "malept/rust-commoncrypto" } | |||
|
|
|||
| [features] | |||
| # default = ["ios-compat"] | |||
| ios-compat = [] | |||
There was a problem hiding this comment.
Why does this need to be behind a feature? Shouldn't it just be gated on the OS?
There was a problem hiding this comment.
So tests can be run on macOS.
There was a problem hiding this comment.
I'm not convinced that's the right way to do it, but I'll do some research when I have some free time.
|
I also removed libc dependency since you can get c_XXX types from std::os::raw |
|
I can confirm that the lib now passes iOS app store requirements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests pass but I have not found a better way of running them then to modify Cargo.toml and uncomment the default feature flag for ios-compat.
I have no idea why this does not work: cargo test --features="ios-compat"