Static build support #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evidently that's what Ruby expects it to be, regardless of target OS.
malept
commented
Oct 5, 2017
| # Whether to use a statically linked extension. | ||
| # | ||
| def static_extension? | ||
| ENV.key?('RUBY_STATIC') || RbConfig::CONFIG['ENABLE_SHARED'] == 'no' |
There was a problem hiding this comment.
RUBY_STATIC as per steveklabnik/ruby-sys#16 (comment)
| # The basename of the Rust shared library, as installed in the {#ruby_extension_path}. | ||
| # | ||
| def shared_library | ||
| @shared_library ||= "#{library_name}.so" |
There was a problem hiding this comment.
Apparently Ruby always expects the file extension to be .so regardless of OS. I guess that makes it simpler.
| end | ||
|
|
||
| args |
|
This passed the Travis CI push check, and the branch is based off of master, so I'm going to just merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22.