Rely on QQC2 styles instead of internal themes #108
Merged
Commits on Jun 29, 2022
-
qml: Fix border color and size on keyboard and popups to not use theme
Use a hard coded value for border color where it should be shown, which is already the same color used in all existing themes. Also set the border width to 1 pixel for all borders.
-
qml: Use Page component for the Keyboard surface
Ensure we get the background from the qqc2 style in use by using a Page component as the main surface for the Keyboard.
-
-
-
-
qml: Fix keys to have no borders and follow qqc2 style
This simplifies the keys a bit by moving the icon properties into CharKey from ActionKey, and removing the color properties, using an ToolButton to show icons on keys that use them. In addition, this also makes the keyboard look a bit more modern.
-
-
-
-
-
plugin: Set icon theme to suru for Suru style, and breeze otherwise
These were the only two icon themes used by the internal themes, so we need to still use them as appropriate, since qqc2 styles themselves don't provide the icons used. Other themes also don't provide the icons we need yet. Ideally, we should just provide all the icons we need ourselves, in a neutral style, so that we don't need to rely on any such themes, but some qqc2 styles which use the default QQuickIconLayout implementation don't always render icons loaded from a qrc resource.
-
-
qml: Make annotations on CharKey appear larger to be more visible
Some keys have annotations that are quite difficult to discern in some situations, so make the label for the annotation a little larger to more easily read them in those cases.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.