refactor: remove lodash.concat as a dependency

malijs · Jun 14, 2021 · a3bb115 · a3bb115
1 parent 7d29bea
commit a3bb115
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 18 deletions.
diff --git a/lib/app.js b/lib/app.js
@@ -246,7 +246,7 @@ class Mali extends Emitter {
           // we have a matching service
           // lets add service-level middleware to that service
           const sd = this.data[serviceName]
-          sd.middleware = _.concat(sd.middleware, fns)
+          sd.middleware = sd.middleware.concat(fns)
 
           return
         } else {
@@ -290,7 +290,7 @@ class Mali extends Emitter {
         throw new Error(`Handler for ${name} already defined for service ${serviceName}`)
       }
 
-      sd.handlers[methodName] = _.concat(sd.middleware, fns)
+      sd.handlers[methodName] = sd.middleware.concat(fns)
     }
   }
 

diff --git a/lib/lo.js b/lib/lo.js
@@ -1,13 +1,11 @@
 const forOwn = require('lodash.forown')
-const concat = require('lodash.concat')
 const isPlainObject = require('lodash.isplainobject')
 const pull = require('lodash.pull')
 const pick = require('lodash.pick')
 const camelCase = require('lodash.camelcase')
 
 module.exports = {
   forOwn,
-  concat,
   isPlainObject,
   pull,
   pick,

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -46,7 +46,6 @@
     "destroy": "^1.0.4",
     "ee-first": "^1.1.1",
     "lodash.camelcase": "^4.3.0",
-    "lodash.concat": "^4.5.0",
     "lodash.forown": "^4.4.0",
     "lodash.isplainobject": "^4.0.6",
     "lodash.pick": "^4.4.0",
@@ -59,7 +58,7 @@
   },
   "devDependencies": {
     "@grpc/grpc-js": "^1.3.2",
-    "@grpc/proto-loader": "^0.6.1",
+    "@grpc/proto-loader": "^0.6.2",
     "async": "^3.2.0",
     "ava": "^3.15.0",
     "benchmarkify": "^2.1.3",