Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes fmt from tests. #563

Merged
merged 1 commit into from Sep 14, 2023
Merged

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Sep 14, 2023

🎉 New feature

Closes #566
Related to #564

Summary

  • Removes fmt usage in the tests suite.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #563 (0a8a4a9) into main (33cfe38) will increase coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 0a8a4a9 differs from pull request most recent head dc89254. Consider uploading reports for the commit dc89254 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
+ Coverage   43.99%   44.03%   +0.03%     
==========================================
  Files         164      164              
  Lines        5423     5423              
  Branches     2890     2890              
==========================================
+ Hits         2386     2388       +2     
+ Misses       1532     1531       -1     
+ Partials     1505     1504       -1     
Files Changed Coverage Δ
include/maliput/routing/phase.h 0.00% <ø> (ø)
include/maliput/routing/route.h 50.00% <ø> (ø)
src/routing/route.cc 80.76% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@stonier stonier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 7b2d96a into main Sep 14, 2023
6 checks passed
@francocipollone francocipollone deleted the francocipollone/remove_fmt_from_tests branch September 14, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove the use of fmt in the test suite.
2 participants