New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local and CI Containers #574
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
=======================================
Coverage 20.71% 20.71%
=======================================
Files 279 279
Lines 11762 11762
Branches 2920 2920
=======================================
Hits 2436 2436
Misses 7813 7813
Partials 1513 1513 |
deffeec
to
9dfe89f
Compare
9dfe89f
to
32c6f04
Compare
32c6f04
to
6490444
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6490444
to
cebca04
Compare
Signed-off-by: Daniel Stonier <d.stonier@gmail.com>
Signed-off-by: Daniel Stonier <d.stonier@gmail.com>
cebca04
to
2e9230d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎉 New feature
Bazel containers for VSCode devcontainers (local) and gcr (CI).
Summary
Containers for vscode devcontainer (local) and the GCR (CI) workflows.
The important tidbit here is that the same
Dockerfile
is sourced for both local and CI workflows.Dockerfile
based on focal, installsbazelisk
adds userzen
, also adds some minor conveniencesdevcontainer.json
that just reflects theDockerfile
to a local vscode workflowcontainers.yml
github action that pushes a container built fromDockerfile
to the org's GCRAn example run of the action: https://github.com/maliput/maliput/actions/runs/6203150728
The only github configuration needed for this action is:
Our organization and repo were already configured.
NB: I had problems fighting permissions on this. Turns out that you can't 'push' to the GCR from in a PR from a fork, even if your user is in both organization and repo with the correct priveleges.
Test it
Devcontainers
Action
Trigger a manual run of the action at https://github.com/maliput/maliput/actions/workflows/containers.yml
Checklist
FYI @liangfok