Adds a test function for LaneEnds. #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
6 tasks
francocipollone
previously approved these changes
Oct 10, 2022
| @@ -97,6 +97,13 @@ ::testing::AssertionResult IsRBoundsClose(const RBounds& rbounds1, const RBounds | |||
| /// within the @p tolerance deviation. | |||
| ::testing::AssertionResult IsHBoundsClose(const HBounds& hbounds1, const HBounds& hbounds2, double tolerance); | |||
|
|
|||
| /// Compares equality of two LaneEnd objects. | |||
| /// @param lane_end1 A LaneEnd object to compare. | |||
| /// @param lane_end1 A LaneEnd object to compare. | |||
agalbachicar
commented
Oct 11, 2022
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
agalbachicar
force-pushed
the
agalbachicar/#10_branchpoint_builder
branch
from
03241ac
to
117115b
Compare
|
I need your approval here once more @francocipollone . I forced pushed last commit to solve the signature. |
francocipollone
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Adds a new function to simplify the testing of LaneEnds
See maliput/maliput_sparse#24 for reference.
Summary
Adds a function to assert equality between two LaneEnds in tests.
Test it
Unit tests are provided.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.