Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds angular_tolerance to the build configurations for malidrive RoadNetworks in the applications #137

Merged

Conversation

agalbachicar
Copy link
Collaborator

🦟 Bug fix

Summary

When trying to pass the angular_tolerance flag to malidrive RoadNetworks, it was parsed but not set as a configuration parameter and only the default was used instead. Now, the value is read from the input arguments and configured into the struct so it is considered when loading a map of that type.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

…Networks in the applications.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agalbachicar agalbachicar merged commit ee53fea into main Apr 16, 2024
4 checks passed
@agalbachicar agalbachicar deleted the agalbachicar/add_angular_tolerance_to_malidrive_maps branch April 16, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants