Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piecwise GroundCurve: Use epsilon instead of tolerance at range validation #119

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Piecwise GroundCurve: Use epsilon instead of tolerance at range validation #119

merged 1 commit into from
Jul 5, 2021

Conversation

francocipollone
Copy link
Collaborator

We weren't consistent in the verification of the range:

  • When creating GroundCurves we check that p1_ - p0_ >= GroundCurve::kEpsilon
  • When creating PiecewiseGroundCurve we were checking that p1_ - p0_ >= linear_tolerance_

Which besides not being consistent it was causing that Roads that are smaller than linear tolerance weren't being able to be loaded.

@francocipollone francocipollone added the bug Something isn't working label Jul 2, 2021
agalbachicar
agalbachicar approved these changes Jul 5, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 0e0b905 into main Jul 5, 2021
@francocipollone francocipollone deleted the francocipollone/ground_curve_fix_throw branch July 5, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar