Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlanView's xodr S continuity check falling outside the tolerance selection mechanism #183

Open
francocipollone opened this issue Oct 14, 2021 · 1 comment

Comments

@francocipollone
Copy link
Collaborator

francocipollone commented Oct 14, 2021

Summary

When the tolerance selection mechanism is working the RoadGeometryBuilder reset the linear tolerance and try to build the
RoadGeometry again.

However, there is one check that is falling outside of that reassign of linear tolerances and it happens at a parser level.(EDITED: See #183 (comment))

https://github.com/ToyotaResearchInstitute/maliput_malidrive/blob/f93c0e4ec4be5d229760cdfda5cb3c4c1255db4d/maliput_malidrive/src/maliput_malidrive/xodr/parser.cc#L774-L778

Given that the DBManager is injected into the RoadGeometryBuilder and the parsing is only made once.

https://github.com/ToyotaResearchInstitute/maliput_malidrive/blob/f93c0e4ec4be5d229760cdfda5cb3c4c1255db4d/maliput_malidrive/src/maliput_malidrive/builder/road_network_builder.cc#L52-L55

Proposal

This verification should be pushed into the RoadGeometryBuilder instead.

@francocipollone
Copy link
Collaborator Author

https://github.com/ToyotaResearchInstitute/maliput_malidrive/blob/f93c0e4ec4be5d229760cdfda5cb3c4c1255db4d/maliput_malidrive/src/maliput_malidrive/builder/road_geometry_builder.cc#L379-L383

This check is actually within the scope of the tolerance selection mechanism. I hadn't realized this because of this reassign that goes against dependency injection.

Pushing this verification from the parser to the building will improve time given that just for that check we are rebuilding the DBmanager(therefore parsing the XML) for each iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant