Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses ros-action-ci in build.yaml workflow. #218

Merged
merged 2 commits into from Jun 13, 2022

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Jun 9, 2022

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone added do-static-analyzer-test Runs scan-build workflow do-clang-test Triggers clang builds in a pull request labels Jun 9, 2022
@francocipollone
Copy link
Collaborator Author

francocipollone commented Jun 9, 2022

CI is failing when running some tests because before running the tests we were requiring to source the install folder, in order to let envars like MALIPUT_MALIDRIVE_RESOURCE_ROOT (which points to install/maliput_malidrive/share/resources) to be valid(via environment hooks).

Some test looks for the resources via this environment variable.
An example of this can be found at

xodr::LoadDataBaseFromFile(utility::FindResource("odr/SingleLane.xodr"), kParserConfiguration);

I assume this is something that will also be a blocker when pushing maliput_malidrive into the ros build farm.
Given that it seems that this needs a refactor, what would be the best approach to follow having in mind other ROS2 packages that may find the same issue?. @agalbachicar @tfoote .

It comes to my mind to add a compile definition pointing to the install/src folder but maybe there is a more ros2-way of doing this.

…ng the tests. (#219)

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone added do-static-analyzer-test Runs scan-build workflow do-clang-test Triggers clang builds in a pull request and removed do-static-analyzer-test Runs scan-build workflow do-clang-test Triggers clang builds in a pull request labels Jun 13, 2022
@francocipollone
Copy link
Collaborator Author

francocipollone commented Jun 13, 2022

I merged #219 into this branch. Retriggering CI

@francocipollone
Copy link
Collaborator Author

Going in as it was approved at #219

@francocipollone francocipollone merged commit f19bc16 into main Jun 13, 2022
@francocipollone francocipollone deleted the francocipollone/use_ros_action_ci branch June 13, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-clang-test Triggers clang builds in a pull request do-static-analyzer-test Runs scan-build workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant