Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses compile definitions to avoid having to source install when running the tests. #219

Conversation

francocipollone
Copy link
Collaborator

Proposes a solution for #218 (comment)

Signed-off-by: Franco Cipollone franco.c@ekumenlabs.com

…ng the tests.

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@agalbachicar
Copy link
Collaborator

Disclaimer: I doubt this is the right way to do things. I think we should consider using https://github.com/ament/ament_cmake/blob/master/ament_cmake_core/doc/resource_index.md , that said, it could be an implementation detail of another API we propose for the sake of this bug in particular.

Why not rely on utility::FindResource? Can't we inject another path to look at for testing purposes? I think that would be the cleaner way to avoid touching every single path resolution.

@francocipollone
Copy link
Collaborator Author

Disclaimer: I doubt this is the right way to do things. I think we should consider using https://github.com/ament/ament_cmake/blob/master/ament_cmake_core/doc/resource_index.md , that said, it could be an implementation detail of another API we propose for the sake of this bug in particular.

I agree that using ament_index for finding resources between different packages is the way to go. e.g: Using maliput_malidrive's resources from delphyne
It is something we should tackle at some point -> maliput/maliput_infrastructure#222

In this particular case, we could be benefited from it, however here we just want to address resources within the package. So for me moment, seems to make sense to go for an easier solution.

Why not rely on utility::FindResource? Can't we inject another path to look at for testing purposes? I think that would be the cleaner way to avoid touching every single path resolution.

utility::FindResourceInPath expects to receive a custom environment variable. I could clean it up a bit but not using the FindResource tool.

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone force-pushed the francocipollone/use_compile_definitions_for_resources branch from 8ccd03d to d47967a Compare June 10, 2022 22:00
@francocipollone
Copy link
Collaborator Author

@agalbachicar wdyt?

Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 15a209c into francocipollone/use_ros_action_ci Jun 13, 2022
@francocipollone francocipollone deleted the francocipollone/use_compile_definitions_for_resources branch June 13, 2022 14:22
francocipollone added a commit that referenced this pull request Jun 13, 2022
* Uses ros-action-ci in build.yaml workflow. (#218)

* Uses compile definitions to avoid having to source install when running the tests. (#219)

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants