Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel module #237

Merged
merged 1 commit into from Sep 20, 2023
Merged

Bazel module #237

merged 1 commit into from Sep 20, 2023

Conversation

stonier
Copy link
Collaborator

@stonier stonier commented Sep 19, 2023

🎉 New feature

Bazel module.

Summary

  • Uses the temporary BCR fork from https://github.com/stonier/bazel-central-registry [1]
  • MODULE.bazel - package and dependency information
  • BUILD.bazel - library and application targets
  • resources/BUILD.bazel - filegroup targets for maps
  • build.yml - a bazel build task

[1] It will take some time to get yaml-cpp, tinyxml and maliput into the BCR itself.

No tests yet, also no idea how to get the plugin framework working with bazel. These will come in followup PR's.

Test it

With #235, load the devcontainer and bazel build //...

See also the CI result: https://github.com/maliput/maliput_malidrive/actions/runs/6239555329/job/16937711920?pr=236

Checklist

  • Signed all commits for DCO

@stonier
Copy link
Collaborator Author

stonier commented Sep 19, 2023

Applications added.

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

WORKSPACE.bazel Outdated Show resolved Hide resolved
.bazelrc Outdated Show resolved Hide resolved
* Uses the temporary BCR fork from
  https://github.com/stonier/bazel-central-registry [1]
* MODULE.bazel - package and dependency information
* BUILD.bazel - library, resources, app rules
* build.yml - a bazel build task

[1] It will take some time to get yaml-cpp, tinyxml and maliput into
the BCR itself.

NB: This is basic build only - tests and a working plugin framework in
bazel yet to come.

Signed-off-by: Daniel Stonier <d.stonier@gmail.com>
@stonier stonier merged commit 9aab1fb into main Sep 20, 2023
3 checks passed
@stonier stonier deleted the stonier/bzlmod branch September 20, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants