[applications] xodr_to_obj #259

stonier · 2023-12-23T05:46:17Z

🎉 New feature

Adds a command line utility for dumping .obj/.mtl files from an xodr.

Also:

Bugfixes the return values of all applications to 0 on success
Adds an xodr that is currently unsupported (spiral geometries) <- I was trying to get a .obj of this road network

Summary

Not fancy, but has the basics for getting a .obj file.

Test it

bazel run //:xodr_to_obj -- --xodr-file=${PWD}/resources/Town07.xodr --out-dir=${PWD}

francocipollone

Thanks for the app. 🚀
ptal at the comments

francocipollone · 2023-12-26T02:07:29Z

MODULE.bazel

@@ -16,3 +16,5 @@ bazel_dep(name = "maliput", version = "1.1.1")
 bazel_dep(name = "tinyxml2", version = "9.0.0")

 bazel_dep(name = "googletest", version = "1.14.0", dev_dependency = True)
+
+local_path_override(module_name="maliput", path="../maliput")


Worth for local use case but probably we don't want to add this local_path_override statement to the repo, right?

Aye, fixed.

francocipollone · 2023-12-26T02:08:26Z

.devcontainer/bazel-zen/devcontainer.json

+    //************************************************************************
+    // 1. Add the following to MODULE.bazel
+    //    local_path_override(module_name="maliput", path="../maliput")
+    // 2. Mount maliputr by uncommenting and patching the path in the section below


nit:

Suggested change

// 2. Mount maliputr by uncommenting and patching the path in the section below

// 2. Mount maliput by uncommenting and patching the path in the section below

francocipollone · 2023-12-26T02:09:15Z

resources/SmallTownRoads.xodr

Does it make sense to defer adding this map until we support Spiral Geometries? #260

I don't mind having it there as a test-driven stub for #260, but I'll take it out of here and create a separate PR for that.

Also bugfixes the return values of all applications to 0 on success and adds an xodr that is currently unsupported (spiral geometries). Signed-off-by: Daniel Stonier <d.stonier@gmail.com>

francocipollone

LGTM

CI failing due to clang-format.

There is bash script tool under tools folder that you can run to automatically format the repo.

./src/maliput_malidrive/tools/reformat_code.sh

stonier · 2024-01-05T14:15:12Z

There is bash script tool under tools folder that you can run to automatically format the repo.

Dang, no ament in my bazel devcontainer. Can you run that for me and push a commit to this branch?

Q: Would it be useful for you to have a ROS devcontainer?

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>

francocipollone · 2024-01-05T14:31:20Z

Q: Would it be useful for you to have a ROS devcontainer?

I would say yes for quick development setup, however as we work with several repositories and in a colcon workspace not sure if will be that straightforward. In Bazel you can work directly on the repo and add as many local_override as you want. So it matches just right.

stonier requested a review from francocipollone December 23, 2023 05:46

stonier mentioned this pull request Dec 23, 2023

Spiral Geometries? #260

Closed

francocipollone requested changes Dec 26, 2023

View reviewed changes

stonier force-pushed the stonier/xodr_to_obj branch 2 times, most recently from 4df8f6a to f6157a1 Compare January 5, 2024 13:46

[applications] xodr_to_obj

2e16456

Also bugfixes the return values of all applications to 0 on success and adds an xodr that is currently unsupported (spiral geometries). Signed-off-by: Daniel Stonier <d.stonier@gmail.com>

stonier force-pushed the stonier/xodr_to_obj branch from f6157a1 to 2e16456 Compare January 5, 2024 13:49

francocipollone previously approved these changes Jan 5, 2024

View reviewed changes

Makes clang format happy.

f486b55

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>

francocipollone dismissed their stale review via f486b55 January 5, 2024 14:20

francocipollone approved these changes Jan 5, 2024

View reviewed changes

francocipollone merged commit cd42b4f into main Jan 5, 2024
4 checks passed

francocipollone deleted the stonier/xodr_to_obj branch January 5, 2024 14:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[applications] xodr_to_obj #259

[applications] xodr_to_obj #259

stonier commented Dec 23, 2023 •

edited

francocipollone left a comment

francocipollone Dec 26, 2023

stonier Jan 5, 2024

francocipollone Dec 26, 2023

stonier Jan 5, 2024

francocipollone Dec 26, 2023

stonier Jan 5, 2024

francocipollone left a comment •

edited

stonier commented Jan 5, 2024 •

edited

francocipollone commented Jan 5, 2024

	// 2. Mount maliputr by uncommenting and patching the path in the section below
	// 2. Mount maliput by uncommenting and patching the path in the section below

[applications] xodr_to_obj #259

[applications] xodr_to_obj #259

Conversation

stonier commented Dec 23, 2023 • edited

🎉 New feature

Summary

Test it

francocipollone left a comment

Choose a reason for hiding this comment

francocipollone Dec 26, 2023

Choose a reason for hiding this comment

stonier Jan 5, 2024

Choose a reason for hiding this comment

francocipollone Dec 26, 2023

Choose a reason for hiding this comment

stonier Jan 5, 2024

Choose a reason for hiding this comment

francocipollone Dec 26, 2023

Choose a reason for hiding this comment

stonier Jan 5, 2024

Choose a reason for hiding this comment

francocipollone left a comment • edited

Choose a reason for hiding this comment

stonier commented Jan 5, 2024 • edited

francocipollone commented Jan 5, 2024

stonier commented Dec 23, 2023 •

edited

francocipollone left a comment •

edited

stonier commented Jan 5, 2024 •

edited