Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xodr] SmallTownRoads.xodr #266

Merged
merged 1 commit into from Jan 5, 2024
Merged

Conversation

stonier
Copy link
Collaborator

@stonier stonier commented Jan 5, 2024

🎉 New feature

A map from the JPN mining project that requires geometric spirals support, see #260.

Test it

No testing yet. Think of it as a test-driven stub awaiting support from #260.

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! one minor comment to go

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing to install it in CMake world. Check the root CMakeLists file. (We don't have a glob there.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, added.

A map from the JPN mining project that requires geometric spirals
support, see #260.

Signed-off-by: Daniel Stonier <d.stonier@gmail.com>
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francocipollone francocipollone merged commit 24b184f into main Jan 5, 2024
4 checks passed
@francocipollone francocipollone deleted the stonier/small_town_roads branch January 5, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants