Adds OSMManager #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
francocipollone
commented
Sep 27, 2022
Comment on lines
+75
to
+80
| install (DIRECTORY resources | ||
| DESTINATION share/${PROJECT_NAME}) | ||
|
|
||
|
|
||
| ament_environment_hooks("${CMAKE_CURRENT_SOURCE_DIR}/env-hooks/${PROJECT_NAME}.dsv.in") | ||
| ament_environment_hooks("${CMAKE_CURRENT_SOURCE_DIR}/env-hooks/${PROJECT_NAME}.sh.in") |
There was a problem hiding this comment.
I'd like to use ament_index here instead, for the resources management.
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
francocipollone
commented
Sep 29, 2022
Comment on lines
47
to
48
| ::testing::AssertionResult CompareLineString3d(const maliput_sparse::geometry::LineString3d& lhs, | ||
| const maliput_sparse::geometry::LineString3d& rhs, double tolerance); |
There was a problem hiding this comment.
I will push this to maliput_sparse::test_utilities as probably it is something to be used by other backends.
6 tasks
agalbachicar
requested changes
Oct 3, 2022
test/osm/conversions_test.cc
Outdated
| } // namespace | ||
| } // namespace test | ||
| } // namespace osm | ||
| } // namespace maliput_osm |
There was a problem hiding this comment.
Suggested change
| } // namespace maliput_osm | |
| } // namespace maliput_osm | |
test/osm/conversions_test.cc
Outdated
| 8, {lanelet::Point3d{5, points_right[0].x(), points_right[0].y(), points_right[0].z()}, | ||
| lanelet::Point3d{6, points_right[1].x(), points_right[1].y(), points_right[1].z()}, | ||
| lanelet::Point3d{7, points_right[2].x(), points_right[2].y(), points_right[2].z()}}); | ||
| const lanelet::Lanelet lanelet(std::stoi(lane_id), lanelet_left, lanelet_right); |
There was a problem hiding this comment.
Suggested change
| const lanelet::Lanelet lanelet(std::stoi(lane_id), lanelet_left, lanelet_right); | |
| const lanelet::Lanelet lanelet(kLaneIdNumber, lanelet_left, lanelet_right); |
test/osm/conversions_test.cc
Outdated
| TEST(ToMaliput, Lanelet) { | ||
| const std::vector<maliput::math::Vector3> points_left{{1., 1., 1.}, {2., 2., 2.}, {3., 3., 3.}}; | ||
| const std::vector<maliput::math::Vector3> points_right{{3., 3., 3.}, {4., 4., 4.}, {5., 5., 5.}}; | ||
| const Lane::Id lane_id{"10"}; |
There was a problem hiding this comment.
Suggested change
| const Lane::Id lane_id{"10"}; | |
| constexpr int kLaneIdNumber{10}; | |
| const Lane::Id lane_id{std::to_string(kLaneIdNumber)}; |
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
agalbachicar
requested changes
Oct 4, 2022
Yep, CI passes now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of #6
Summary
maliput_osm::osm::segmentstructsChecklist