Addresses final comments.

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
maliput · Dec 23, 2022 · eeb7c16 · eeb7c16
1 parent be8e284
commit eeb7c16
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/parser/validation_methods.h b/src/parser/validation_methods.h
@@ -42,8 +42,8 @@ namespace parser {
 /// @param validate_geometric_adjacency Whether to validate geometric adjacency.
 /// @param config The maliput_sparse::parser::ValidatorConfig to use.
 /// @returns A vector of maliput_sparse::parser::Validator::Error.
-std::vector<Validator::Error> ValidateLaneAdjacency(const Parser* parser, const bool& validate_geometric_adjacency,
-                                                    const ValidatorConfig config);
+std::vector<Validator::Error> ValidateLaneAdjacency(const Parser* parser, bool validate_geometric_adjacency,
+                                                    const ValidatorConfig& config);
 
 }  // namespace parser
 }  // namespace maliput_sparse
diff --git a/src/parser/validator.cc b/src/parser/validator.cc
@@ -96,8 +96,8 @@ std::vector<Validator::Error> Validator::operator()() const {
   return errors;
 }
 
-std::vector<Validator::Error> ValidateLaneAdjacency(const Parser* parser, const bool& validate_geometric_adjacency,
-                                                    const ValidatorConfig config) {
+std::vector<Validator::Error> ValidateLaneAdjacency(const Parser* parser, bool validate_geometric_adjacency,
+                                                    const ValidatorConfig& config) {
   std::vector<Validator::Error> errors;
   auto evaluate = [&errors](bool condition, const std::string& message, const Validator::Type& error_type) {
     if (condition) {