Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial project skeleton. #2

Merged
merged 2 commits into from Aug 8, 2022
Merged

Conversation

agalbachicar
Copy link
Contributor

馃帀 Project skeleton

Closes #1

Summary

Adds a project skeleton to work in the maliput ecosystem.

Test it

Automated tests should pass.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
francocipollone
francocipollone previously approved these changes Aug 2, 2022
Copy link
Contributor

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 馃殌 馃殌

.github/dependencies.repos Outdated Show resolved Hide resolved
.github/workflows/triage.yml Show resolved Hide resolved
BSD 3-Clause License

Copyright (c) 2022, Woven Planet. All rights reserved.
Copyright (c) 2019-2022, Toyota Research Institute. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use here only Copyright (c) 2022, Woven Planet. All rights reserved.?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw it but I was not sure. @stonier can you help us here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it as it and then proceed to remove it in case it is required in a differen PR.

src/CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Copy link
Contributor

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agalbachicar agalbachicar merged commit f8ce525 into main Aug 8, 2022
@agalbachicar agalbachicar deleted the agalbachicar/package_setup branch August 8, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add project skeleton
2 participants