Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds compare method for the LineStrings. #28

Merged
merged 1 commit into from Oct 4, 2022
Merged

Adds compare method for the LineStrings. #28

merged 1 commit into from Oct 4, 2022

Conversation

francocipollone
Copy link
Contributor

Related to maliput/maliput_osm#7 (comment)

Summary

Adds convenient method to be used in tests for comparing maliput_sparse::geometry::LineString3d s

@francocipollone
Adds compare method for the LineStrings.
60be595 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
agalbachicar
agalbachicar approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@agalbachicar agalbachicar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should use it in our tests (in this package) also.

@francocipollone francocipollone merged commit e39cad8 into main Oct 4, 2022
@francocipollone francocipollone deleted the francocipollone/osm_manager branch October 4, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Maliput - Core development
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@francocipollone @agalbachicar