Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass by reference to followChain #41

Merged
merged 3 commits into from
Sep 11, 2021
Merged

Pass by reference to followChain #41

merged 3 commits into from
Sep 11, 2021

Conversation

dmaljovec
Copy link
Collaborator

What?

Why?

  • Performance improvement with no side effects since this is a read-only data structure.

dmaljovec and others added 3 commits September 8, 2021 06:13
@dmaljovec
Pass by reference to followChain
0bff928 
What?
=======

- Incorporate suggestion by @senth27 in #39

Why?
=====

- Performance improvement with no side effects since this is a read-only data structure.
@dmaljovec
* ignore type checking errors for libraries without type hints
3e74374
@dmaljovec
* test more relevant python versions
d2293d2
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.2% when pulling d2293d2 on senth27-suggestion into 3947fad on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.2% when pulling d2293d2 on senth27-suggestion into 3947fad on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.2% when pulling d2293d2 on senth27-suggestion into 3947fad on master.

@dmaljovec dmaljovec marked this pull request as ready for review September 11, 2021 12:12
@maljovec maljovec merged commit 73ccc95 into master Sep 11, 2021
@maljovec maljovec deleted the senth27-suggestion branch September 11, 2021 12:19
@maljovec maljovec mentioned this pull request Sep 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmaljovec @coveralls @maljovec