-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/test cases #691
Fix/test cases #691
Conversation
Fixing ```bash ReferenceError: ENABLE_INNER_HTML is not defined ``` More details can be found here https://docs.taro.zone/docs/external-libraries/#jest
Navbar test case fixed
这个我会提示 window 的错误,你那边是正常的么。 |
Can you please share error details? |
For me it's working fine. Node Version: v20.9.0 |
thx~, what is your jest version? |
Jest, I'm using the same. which is mentioned in package.json file. ^26.6.0 |
Node Version: v20.9.0 Thank you! 🎉 |
Are you getting any warning as well while running the test cases. Regarding React Render something? |
Yeah okay. I'm working on test coverage to increase it more. Along with that I'll fix this warning message also. |
@Pilotager , I observed one thing. yarn clean yarn develop yarn test I did this and that warning stopped appearing while running tests, but if I'm following the same steps but instead of |
lodash/babel-plugin-lodash#260 Check this article once |
the warning is harmless, but nonetheless annoying. |
This PR is to fix test cases. Currently if you're running
yarn test
it's throwing various errors
To fix this, globals has been added. Here is the reference link: https://docs.taro.zone/docs/external-libraries/#jest.
Next fix is to map
@tarojs/components
correctly. Currently injest.config.js
it was mapped to@tarojs/components/dist-h5/react
. Due to which runningyarn test
was throwing below error.But this path doesn't exists. Now it should be mapped to
@tarojs/components/lib/react
, likeLast fix is for
packages/core/src/navbar/__tests__/navbar.test.tsx
where invalid constant was exported from styles. Now it's corrected toimport { HAIRLINE_BORDER_BOTTOM } from "../../styles/hairline"