Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Collapse] Value is undefined #94

Merged
merged 1 commit into from Nov 11, 2021
Merged

[Collapse] Value is undefined #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/core/src/collapse/collapse.tsx
View file
Open in desktop
Expand Up @@ -66,8 +66,16 @@ export interface CollapseProps extends ViewProps {
}

function Collapse(props: CollapseProps) {
const { className, bordered, value = "", accordion = false, onChange, ...restProps } = props
const { items } = useCollapseChildren(props.children)
const {
className,
bordered,
value = "",
accordion = false,
onChange,
children: childrenProp,
...restProps
} = props
const { items } = useCollapseChildren(childrenProp)

const toggleItem = useCallback(
(itemValue: number | string, expanded: boolean) => {
Expand All @@ -87,7 +95,6 @@ function Collapse(props: CollapseProps) {
if (process.env.NODE_ENV !== "production" && !validateActiveValue(value, accordion)) {
return false
}

return accordion ? value === itemValue : (value as Array<number | string>).includes(itemValue)
},
[accordion, value],
Expand Down