Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad parse causes syntax highlighting to disappear #35

Closed
anikaks opened this issue Sep 28, 2021 · 1 comment
Closed

Bad parse causes syntax highlighting to disappear #35

anikaks opened this issue Sep 28, 2021 · 1 comment

Comments

@anikaks
Copy link
Contributor

anikaks commented Sep 28, 2021

@christopherswenson had written:
@mtoy-googly-moogly It seems like we're no longer highlighting when there's a bad parse again.

I can look into this, but wanted to give you a heads up.

@mtoy-googly-moogly had responded:
What I thought you asked was for me to do the "highlight", which only depends on the token stream, even if the parse failed. I believe this is what is implemented. The "symbols" pass is only run if the parse runs without errors.

Are you saying that the "highlight" recognizer is not running when there are syntax errors, but it once did.

Are you saying the "highlight" recognizer has always been skipped on syntax errors?

Are you saying that I misunderstood you and you expect the "symbols" recognizer to be run, even when the parse returns syntax errors?

@anikaks
Copy link
Contributor Author

anikaks commented Oct 26, 2021

resolved!

@anikaks anikaks closed this as completed Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant