Fix for Issue231 artwork error #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This prevents scraper errors from throwing UI errors on each request (ref maloep#188)
… easily find the error in the log while the message is displayed
|
I appreciate you're busy with other commitments, but have you had a chance to review this and some of the other PRs? I have other changes I'd like to propose but these are dependent on this and other PRs being merged. |
|
Sorry for the delay. I hope that I can check and merge the PRs in the next days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #231
When artwork download fails, return expected number of values
Log errors before displaying dialog so user can inspect the log while
the error is displayed on screen