Some small fixes for running on slurm #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 81.58% 81.66% +0.07%
==========================================
Files 4 4
Lines 516 518 +2
==========================================
+ Hits 421 423 +2
Misses 95 95
Continue to review full report at Codecov.
|
|
It seems like you have accidentally committed the same changes as #59. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few small fixes which are needed in order to get any jobs to run on the SLURM scheduler.
The point of this isn't so much to be merged, but more that I couldn't be bothered to make separate issues for each one of these errors.
It contains one error to do with the job name, one to do with how job arrays are specified, one to do with cpus per task, plus a hack I had to put in because of the time conversion I mentioned in another issue.